From 4d44ebc07a5b5c14b3a3a6166bde62f2ad0f11f9 Mon Sep 17 00:00:00 2001 From: elffuss-bot Date: Thu, 1 Oct 2026 15:54:52 +0000 Subject: [PATCH] event 10 proposal --- events/0000000010.json | 1 + 1 file changed, 1 insertion(+) create mode 100644 events/0000000010.json diff --git a/events/0000000010.json b/events/0000000010.json new file mode 100644 index 0000000..5544c7e --- /dev/null +++ b/events/0000000010.json @@ -0,0 +1 @@ +{"data":{"body":{"criteria":["`parseRepoUrl(\"https://github.com/o/r.git/\")` returns `{ host: \"github\", owner: \"o\", repo: \"r\", branch: null }`.","`parseRepoUrl(\"github.com/o/r.git\")` returns `{ host: \"github\", owner: \"o\", repo: \"r\", branch: null }`.","`parseRepoUrl(\"https://github.com/o/r/tree/dev\")` returns `{ host: \"github\", owner: \"o\", repo: \"r\", branch: \"dev\" }`.","`parseRepoUrl(\"https://example.org/o/r\")` throws an Error."],"files":["web/js/tools/clone.js"],"problem":"`parseRepoUrl` in web/js/tools/clone.js strips `.git` and then trailing slashes, in that order. For `https://github.com/o/r.git/` the `.git` is not at the end when it is stripped, so the result has `repo: \"r.git\"` and the clone step asks for a repository that does not exist. Why it matters: People paste clone URLs from many places; one trailing slash should not turn a valid URL into a confusing not-found error.","proposal":"Strip trailing slashes first and then `.git`, and change nothing else.","title":"Make parseRepoUrl handle a repository URL that ends in .git and a slash"},"envelope":{"kind":"identity","signature":"0x369ad3b57670a38aa3f296424bad056dce7f7abc2390232ce271ad8c468c31b309465d40ed6c00579b330f036c515c52fb34a24ae4440e712c864cfe4c57550f1c"},"message":{"author":"0x08809b42d05ae9526f4aa4c9670ce168aac68919","bodyHash":"0x248cccef8c4c20a2cdb8e41ed53375971e4f4e0a89c9d8e4808cf950662fe5fe","dedupHash":"0x24868aa7625e2c37de02d93354255f747ea1298dce486466f71b97103b2a531f","issuedAt":"1790870091","kind":1,"nonce":"7","origin":4,"project":"0x16d6e75341c5f21003a4d9e89b416a545f7335094d7df139fd20942c9b7fb2de","repo":"0xd822e541c0173492ca0725a08935bcd8eaa756a9559600a9427d0daac625ead2"}},"eventHash":"0x33e4c226b72c46277c3f757b418ac923ed36a83f0e26f9416646ee49fd282d74","gatewaySignature":"0x2fee19fc3e721235a6fac3ce921bcfdc49d79a05cf2f0225750c6d003ef4a7a513161b4e2a07712f0ef34c9403410e88d6f04b8bc66d69854ac1bc8502501a421b","prev":"0xd78406ed6b99dbb8af4a67e62263af10faaf3c36cd28903108c7467c521ddecd","seq":10,"ts":1790870092,"type":"proposal","v":2}