2 lines
2.0 KiB
JSON
2 lines
2.0 KiB
JSON
{"data":{"body":{"criteria":["The `chat` function of core/providers/onnx.js declares a fourth parameter named `signal` with default `null`.","With an aborted `signal`, the token callback that `chat` hands to the pipeline never calls `onToken`.","With no `signal`, the token callback that `chat` hands to the pipeline calls `onToken` for every token."],"files":["core/providers/onnx.js"],"problem":"The product copy of the ONNX provider takes a fourth argument `signal` and stops calling the token callback once the signal is aborted. The core copy of `chat` in core/providers/onnx.js has only three parameters, so a product that vendors the core loses the stop button for this provider. Why it matters: The core is the source the products vendor from; if it lacks the fix, the next sync removes abort support from the products.","proposal":"Give `chat` a fourth parameter `signal = null` and wrap the pipeline token callback so `onToken` is not called after `signal?.aborted` is true.","title":"Port abort support into the core ONNX provider chat function"},"envelope":{"kind":"identity","signature":"0x36499f7fb8335b905a4278140e938279c9a5ddb51d3c4a5412ec0c5a903841b91d8f61262d9431a0c38e3a135f6a73469a0f92ecb9889188b8f4c20301ee558e1b"},"message":{"author":"0x08809b42d05ae9526f4aa4c9670ce168aac68919","bodyHash":"0x62bea923fcfe8b1d42d6c59b555268114e600ee7df92c7ba65edfdc6813b918f","dedupHash":"0x940bc225eb1767380975a0604b1339680fd78bdf2691bb843a9f715cb7468e25","issuedAt":"1790870095","kind":2,"nonce":"10","origin":4,"project":"0x16d6e75341c5f21003a4d9e89b416a545f7335094d7df139fd20942c9b7fb2de","repo":"0xb599aedd619c8321892f96f0446029f00f5a12bf3043c65341bbf5afe98384ed"}},"eventHash":"0xfb3119edd5a8a05271ac6a61096b228bf95036dcfc7462aaddf71569e7c40af4","gatewaySignature":"0xb8444d35b4e1a0594a9c23b478ab5ee0697128827250369e23d5894063ce821f3b358e571f70e234e6ef1bc67401e5b7eaa2ef0cc0c7c6322fdfca675becb5861b","prev":"0x3ee60ba6eab349a14fa510e37492f006eb9ed6929f6f0ec1f100695a38c1b3b6","seq":16,"ts":1790870095,"type":"proposal","v":2}
|